This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
Update Cats Version and Other Compatible Shifts #204
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9aa6983
Update Cats Version and Other Compatible Shifts
ChristopherDavenport 0817bdd
Update Travis Scala Versions
ChristopherDavenport b1d7d76
Update Scala 2.12 and Scala-Js Version
ChristopherDavenport 479d84e
Fix Travis 2.12 and Gitignore Intellij
ChristopherDavenport 4b3462c
Switch from DomNode to NodeJS jsEnv
ChristopherDavenport bc9786a
Remove Bad Implicits from 2.12
ChristopherDavenport File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,13 +7,13 @@ import com.typesafe.tools.mima.plugin.MimaPlugin.mimaDefaultSettings | |
lazy val scalaCheckVersion = "1.13.4" | ||
lazy val scalaTestVersion = "3.0.1" | ||
lazy val disciplineVersion = "0.7.2" | ||
lazy val catsVersion = "0.9.0" | ||
lazy val catsVersion = "1.0.0-MF" | ||
lazy val catalystsVersion = "0.0.5" | ||
|
||
lazy val buildSettings = Seq( | ||
organization := "org.typelevel", | ||
scalaVersion := "2.12.1", | ||
crossScalaVersions := Seq("2.10.6", "2.11.8", "2.12.1") | ||
crossScalaVersions := Seq("2.10.6", "2.11.11", "2.12.1") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we change to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So the dilemma is that these require scala-js changes which require changes to your I didn't want to do that on the original PR in case you wanted to have a minimal dependency shift, however I can get these done. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Apparently so did, |
||
) | ||
|
||
lazy val commonSettings = Seq( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
sbt.version=0.13.13 | ||
sbt.version=0.13.16 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not bump to 2.12.3?