Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move relevant function instances into kernel #1320

Closed
non opened this issue Aug 22, 2016 · 1 comment · Fixed by #1324
Closed

Move relevant function instances into kernel #1320

non opened this issue Aug 22, 2016 · 1 comment · Fixed by #1324
Assignees

Comments

@non
Copy link
Contributor

non commented Aug 22, 2016

Right now we have a Monoid for Function1 values in cats-core. I think it makes sense to move the definition to cats-kernel since that's where monoids are defined -- this will allow algebra and other kernel-dependents to share these instances.

(More generally, I think where possible all orderings, monoids, etc. should live in cats-kernel.)

@johnynek
Copy link
Contributor

+1 to this
On Mon, Aug 22, 2016 at 06:14 Erik Osheim [email protected] wrote:

Right now we have a Monoid for Function1 values in cats-core. I think
it makes sense to move the definition to cats-kernel since that's where
monoids are defined -- this will allow algebra and other
kernel-dependents to share these instances.

(More generally, I think where possible all orderings, monoids, etc.
should live in cats-kernel.)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1320, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEJdt-ASZX8UhEWkQ_7DBIEdTjWGTYCks5qicrEgaJpZM4JqCo-
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants