-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Show instances #607
Comments
I was going to add an instance for Anyway, the thing with Before I go too deep down this road, the question I have is whether a The next layer of the onion is that there are My feeling is that all of these make sense at some level, and that Let me know what you think. |
@mikejcurry I'm about to go somewhere, but there's one simple part of this that I can address first :). The |
Aah ok, I missed those for some reason. Sorry about that. |
@mikejcurry Thank you for brining up the rabbit hole you went down with |
I've tried to add a Show instance for WriterT with the following pull request: #928. Just trying to get my feet wet here with some "low-hanging fruit" so I'd welcome any and all feedback. |
Since #928 is merged, shouldn't this issue be closed? |
@rabbitonweb I suspect there are more missing, but this is a pretty broad/vague issue, so if we find any we should probably create a separate issue for them. Thanks for the heads up - I'll close this out. |
@ceedubs I'm sort of looking for a low hanging fruit - an entrypoint to contribution to cats, maybe if u could find one for, creating a Show instance would be a good starting point |
Many data types already have
Show
instances (and more will after #600, #601, and #602 are merged). However, there are still a few that are missing. Two that I see at the moment areandProd
WriterT
. We should add those and any others we can find that are missing.Edit: removed
Prod
from the scope of this issue per https://github.com/non/cats/issues/607#issuecomment-155074440.The text was updated successfully, but these errors were encountered: