Revert "Disable scaladoc during packaging for scala 2.10" #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 |
|
👍 Thanks! |
|
Hey folks - sorry about that. Thanks for reverting. |
|
@kailuowang This has come up again in #1041. I noticed that circe is doing this to omit sources in the doc. Did you ever try anything like that without changing |
|
@ceedubs yeah, that might work, let me give it a try (i wonder if it still creates the java-doc jar and thus pass the sonatype test) |
|
seems working, PR #1051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling docs for scala 2.10 can't be achieved by this change alone. Sonatype release requires javadoc jars, this is now blocking the 0.5.0 release. My proposal is that we revert this for now and find a more comprehensive solution for #898 later. I know it's kicking the can down the road, but this PR itself does not bring any value to 0.5.0, so I think it is sensible to not having it blocking the release.
Update: #898 is not included in the 0.5.0 release.