Remove blocking (JVM-only) Future instances #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes typelevel#589. If anyone is set on using these, they can be added to alleycats. However, I suspect that few to no people are using these. They all throw exceptions on failed futures, which seems like it would be a show-stopper in most codebases.
|
Build failure? But 👍 |
|
@adelbertc yeah, I don't completely understand the failure. The build passed. The code coverage check is complaining. It seems that it doesn't know how to handle the fact that I removed a couple classes and their tests? I'm not sure. |
Current coverage is 81.75%
@@ master #1018 diff @@
==========================================
Files 215 214 -1
Lines 2720 2696 -24
Methods 2657 2631 -26
Messages 0 0
Branches 58 60 +2
==========================================
- Hits 2415 2204 -211
- Misses 305 492 +187
Partials 0 0
|
|
I've resolved the merge conflict. |
|
If no one object I'm fine with this. 👍 |
|
👍 |
1 similar comment
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #589.
If anyone is set on using these, they can be added to alleycats.
However, I suspect that few to no people are using these. They all throw
exceptions on failed futures, which seems like it would be a
show-stopper in most codebases.