Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add law-checking for asMeetPartialOrder and asJoinPartialOrder #1022

Merged
merged 3 commits into from
May 9, 2016

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented May 8, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented May 8, 2016

Current coverage is 82.03%

Merging #1022 into master will not change coverage

@@             master      #1022   diff @@
==========================================
  Files           215        215          
  Lines          2699       2699          
  Methods        2631       2631          
  Messages          0          0          
  Branches         64         64          
==========================================
  Hits           2214       2214          
  Misses          485        485          
  Partials          0          0          

Powered by Codecov. Last updated by 1837862...331e739

@ceedubs
Copy link
Contributor Author

ceedubs commented May 8, 2016

hmm I don't understand why this didn't affect code coverage. I'll have to
investigate.
On May 8, 2016 10:42 AM, "Codecov" [email protected] wrote:

Current coverage https://codecov.io/gh/typelevel/cats/pull/1022?src=pr
is 82.03%

Merging #1022 https://codecov.io/gh/typelevel/cats/pull/1022?src=pr
into master https://codecov.io/gh/typelevel/cats/branch/master?src=pr
will not change coverage

@@ master #1022 diff @@

Files 215 215
Lines 2699 2699
Methods 2631 2631
Messages 0 0

Branches 64 64

Hits 2214 2214
Misses 485 485
Partials 0 0

Powered by Codecov https://codecov.io?src=pr. Last updated by
1837862...331e739
https://codecov.io/gh/typelevel/cats/compare/18378628dd326ecb10e02387799e86a98aac8e92...331e739a87f37ee76d4ef71d4e9c83d58d088763


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1022 (comment)

@ceedubs
Copy link
Contributor Author

ceedubs commented May 9, 2016

I think that the build/validate aliases in the build.sbt aren't quite right. I'm testing some changes locally and should be adding a commit to this PR shortly.

@non
Copy link
Contributor

non commented May 9, 2016

Sounds good. I'm 👍 on this PR either way.

@ceedubs
Copy link
Contributor Author

ceedubs commented May 9, 2016

Okay, I'm not quite sure what codecov is complaining about now, but it looks like the build changes resulted in +6% coverage being reported.

@adelbertc
Copy link
Contributor

👍 woot woot!

@ceedubs ceedubs merged commit 4285a07 into typelevel:master May 9, 2016
@ceedubs ceedubs deleted the semilattice-tests branch May 9, 2016 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants