Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coproduct fold #1032

Merged
merged 1 commit into from
May 15, 2016
Merged

Conversation

peterneyens
Copy link
Collaborator

Add the fold operation for Coproduct mentioned in #987.
I am not sure how I could test this ?

@codecov-io
Copy link

codecov-io commented May 14, 2016

Current coverage is 88.74%

Merging #1032 into master will decrease coverage by <.01%

  1. 2 files (not in diff) in ...n/scala/cats/functor were modified. more
  2. 2 files (not in diff) in .../src/main/scala/cats were modified. more
@@             master      #1032   diff @@
==========================================
  Files           215        215          
  Lines          2726       2727     +1   
  Methods        2664       2663     -1   
  Messages          0          0          
  Branches         57         59     +2   
==========================================
  Hits           2420       2420          
- Misses          306        307     +1   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 3febb06...74754ed

@ceedubs
Copy link
Contributor

ceedubs commented May 14, 2016

Thanks @peterneyens. I think this method is pretty much guaranteed to be implemented correctly if the types line up, so I'm not too worried about testing it. But it would also be nice to not have it reported as uncovered code. Would you be interested in writing an sbt-doctest example in the scaladoc? I think that would kind of knock out two birds with one stone, because it may be helpful for people and it should count as test coverage. You can could use simple NaturalTransformations such as the listToOption one that is used in NaturalTransformationTests.

@adelbertc
Copy link
Contributor

👍

@ceedubs
Copy link
Contributor

ceedubs commented May 15, 2016

Awesome. Thanks!

@ceedubs ceedubs merged commit 93dc315 into typelevel:master May 15, 2016
@peterneyens peterneyens deleted the add-coproduct-fold branch May 16, 2016 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants