Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Xor with Either, fixes #1192 #1289

Merged
merged 8 commits into from
Aug 20, 2016
Merged

Replace Xor with Either, fixes #1192 #1289

merged 8 commits into from
Aug 20, 2016

Commits on Aug 15, 2016

  1. Prefer Either over Xor, fixes typelevel#1192 

    This commit keeps Xor and XorT but moves most Cats functions from Xor to Either.
Xor will be removed after 0.8.0.

- Add methods from Xor onto enrichment class of Either
- Copy XorT into an EitherT based around Either
- Styling: Occurences of Either are styled as Either[A, B] instead of A Either B (as it was in Xor)
    @adelbertc
    adelbertc committed Aug 15, 2016
    Configuration menu
    Copy the full SHA
    3bc775f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into stdlib-eithert

    @adelbertc
    adelbertc committed Aug 15, 2016
    Configuration menu
    Copy the full SHA
    21bab6b View commit details
    Browse the repository at this point in the history

  3. Add Either(T) tests and replace Xor with Either in tests

    @adelbertc
    adelbertc committed Aug 15, 2016
    Configuration menu
    Copy the full SHA
    a43527f View commit details
    Browse the repository at this point in the history

  4. ScalaStyle fixes

    @adelbertc
    adelbertc committed Aug 15, 2016
    Configuration menu
    Copy the full SHA
    8fc564e View commit details
    Browse the repository at this point in the history

  5. Fix ScalaDoc, address comments 

    - Remove variance workarounds since Either syntax is invariant
- Prefer pattern matching over fold for performance
- Fix ScalaDoc
- Replace ad-hoc casts with leftCast and rightCast
- Re-enable ScalaStyle after disables and disable ScalaStyle on Either.type enrichment
    @adelbertc
    adelbertc committed Aug 15, 2016
    Configuration menu
    Copy the full SHA
    4530d3a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2016

  1. Eval uses defaultTailRecM

    @adelbertc
    adelbertc committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    d4df094 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2016

  1. Safer Either casting

    @adelbertc
    adelbertc committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    eedd057 View commit details
    Browse the repository at this point in the history

  2. Expose Left/Right cast syntax - casting naming indicates which type p… 

    …arameter to cast
    @adelbertc
    adelbertc committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    ba1a786 View commit details
    Browse the repository at this point in the history