Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix many cats-kernel instances. #1324

Merged
merged 7 commits into from
Aug 24, 2016
Merged

Fix many cats-kernel instances. #1324

merged 7 commits into from
Aug 24, 2016

Commits on Aug 23, 2016

  1. Fix many cats-kernel instances. 

    This commit does a bunch of things:

 1. Move relevant either/function instnaces into kernel
 2. Add missing Eq/PartialOrder instances for Either
 3. Add many missing instances for Function0/Function1
 4. Add instances for BitSet
 5. Remove code duplication between collection monoids
 6. Improve test coverage of function instances
 7. Add some missing package objects in kernel
 8. A few stylistic changes

This is a relatively large commit but I think almost all of this is
stuff we'd like to get done before we freeze cats-kernel.
    @erik-stripe
    erik-stripe committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    706effc View commit details
    Browse the repository at this point in the history

  2. Check BitSet instances (and Set's semilattice).

    @erik-stripe
    erik-stripe committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    aeee001 View commit details
    Browse the repository at this point in the history

  3. Replace Either#fold with pattern match in instances.

    @erik-stripe
    erik-stripe committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    e2e0996 View commit details
    Browse the repository at this point in the history

  4. Fix type mismatch.

    @erik-stripe
    erik-stripe committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    cffe60f View commit details
    Browse the repository at this point in the history

  5. Add Semigroup[Either[A, B]] and save some allocations. 

    This is for you, @johnynek.
    @erik-stripe
    erik-stripe committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    db2eab3 View commit details
    Browse the repository at this point in the history

  6. One last allocation.

    @erik-stripe
    erik-stripe committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    2d3b474 View commit details
    Browse the repository at this point in the history

  7. Fewer allocations (and fix type error).

    @erik-stripe
    erik-stripe committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    24e4de2 View commit details
    Browse the repository at this point in the history