Add EitherT.fromOption

[markus1189]

Adds EitherT.fromOption which es the equivalent of Either.fromOption but directly lifts into an Applicative.

[johnynek]

👍

[codecov-io]

Current coverage is 91.47% (diff: 50.00%)

Merging #1327 into master will decrease coverage by 0.07%

@@             master      #1327   diff @@
==========================================
  Files           237        237          
  Lines          3563       3568     +5   
  Methods        3504       3506     +2   
  Messages          0          0          
  Branches         59         61     +2   
==========================================
+ Hits           3262       3264     +2   
- Misses          301        304     +3   
  Partials          0          0          

Powered by Codecov. Last update 3ca2309...50db00c

[johnynek]

looks like we need to add a test to improve coverage.

[markus1189]

Yeah I will have a look tomorrow

On Aug 23, 2016 22:51, "P. Oscar Boykin" [email protected] wrote:

looks like we need to add a test to improve coverage.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1327 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAkGz-hiZIVO9TDkDa0JPXStb_Hr91T4ks5qi11YgaJpZM4JrUr-
.

[markus1189]

I am pretty sure that the line as reported by codecov is hit. Is there anything special I have to do or does codecov simply not detect this?

[johnynek]

If you look here:

https://codecov.io/gh/typelevel/cats/compare/3ca2309fcb666054211c643dac8f5346224d7ff8...50db00cd02a51f0fcf760e03db857c5a400de7ec

It seems to think: EitherT(F.pure(Either.fromOption(opt, ifNone))) is never exercised.

Can you show where it is tested?

[markus1189]

1. In the doctests

[markus1189]

@johnynek I added the comments where I exercise that line

[johnynek]

yeah, looks like a bug in code-coverage to me. Or maybe somehow the test is not run.

[kailuowang]

👍 , I agree it looks like a codecov bug that missed the apply methods.