-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EitherT.fromOption #1327
Add EitherT.fromOption #1327
Conversation
👍 |
Current coverage is 91.47% (diff: 50.00%)@@ master #1327 diff @@
==========================================
Files 237 237
Lines 3563 3568 +5
Methods 3504 3506 +2
Messages 0 0
Branches 59 61 +2
==========================================
+ Hits 3262 3264 +2
- Misses 301 304 +3
Partials 0 0
|
looks like we need to add a test to improve coverage. |
Yeah I will have a look tomorrow On Aug 23, 2016 22:51, "P. Oscar Boykin" [email protected] wrote:
|
e6b1582
to
50db00c
Compare
I am pretty sure that the line as reported by codecov is hit. Is there anything special I have to do or does codecov simply not detect this? |
If you look here: It seems to think: Can you show where it is tested? |
* scala> EitherT.fromOption[List](o, "Answer not known.") | ||
* res0: EitherT[List, String, Int] = EitherT(List(Left(Answer not known.))) | ||
* scala> EitherT.fromOption[List](Some(42), "Answer not known.") | ||
* res1: EitherT[List, String, Int] = EitherT(List(Right(42))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In the doctests
@johnynek I added the comments where I exercise that line |
yeah, looks like a bug in code-coverage to me. Or maybe somehow the test is not run. |
👍 , I agree it looks like a codecov bug that missed the |
Adds
EitherT.fromOption
which es the equivalent ofEither.fromOption
but directly lifts into anApplicative
.