-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #1297 #1334
Fix for #1297 #1334
Conversation
Current coverage is 91.39% (diff: 95.16%)@@ master #1334 diff @@
==========================================
Files 237 237
Lines 3567 3568 +1
Methods 3502 3504 +2
Messages 0 0
Branches 64 63 -1
==========================================
+ Hits 3260 3261 +1
Misses 307 307
Partials 0 0
|
Thanks @mgttlinger! One thing I'm wondering -- is |
|
Soooooo, should I change anything? Or how does this move forward? |
@mgttlinger I think at this point we should get more sign-offs on the change, particularly since changing names is a breaking change. I'll try to ping folks in the channel to get them to weigh-in. |
I will fix the conflicts once it has been decided if my changes are OK at all. |
So at this point here are the things on my mind, ranked in order of importance (from my point of view):
The wrinkle here is that we've introduced a In the current code, we already have (1) and (2) from my point of view (there are two ways to get I see two clear ways forward: First, we could rename the Bi- type classes (other than The other option I see is to do nothing. I don't think the possible confusion between I'm fine with either of those approaches. What do you all think? @mgttlinger, what is your opinion on the best way to move forward? Please let me know if I'm missing some of the motivation for these changes. |
@non @mgttlinger Since it's not clear which direction we want to go here, mind if we push this to after 0.8.0? |
I'm fine with putting this off until after 0.8.0 personally. |
The main motivation for those changes is that a "bi-" prefix seems to communicate that something is the thing following as well as its dual in mathematics. I'm fine with delaying that change further but I think it would definitely make sense to change those names eventually. If we can come up with a cooler name than |
Closing as this probably won't get merged and is too outdated by now |
We now have the problem of two
map2
methods with different signatures.