Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MonadFilter, and fix MonadCombineLaws #1342

Closed
wants to merge 1 commit into from

Commits on Sep 1, 2016

  1. Remove MonadFilter, and fix MonadCombineLaws

    Fixes typelevel#1336
    
    The `MonadCombine` typeclass unifies `Monad`, `FunctorFilter`, and
    `MonoidK`, bringing three of the lineages together. This uses the
    emptiness notion introduced in `MonoidK` and `flatMap` to implement
    `mapFilter`, along with `unite`.
    
    Given that `MonadCombine` exists, which is Cats equivalent of
    `MonadPlus` there's no need for `MonadFilter` to exist.
    
    The laws are migrated over from `MonadFilter` to `MonadCombine`, except
    these laws would now check  identity laws and the consistencies against
    the correct `F.empty` from `MonoidK`.
    eed3si9n committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    5e0165b View commit details
    Browse the repository at this point in the history