-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Proposal for the Cats Microsite #1369
Conversation
* Removes sbt-site and tut plugins since they are transitive dependencies from sbt-microsite plugin * Updates some configurations that are deprecated in the old 0.8 version of the sbt-site plugin. sbt-microsite plugin is using the 1.0.0 * Modifies all the documentation structure according to the new proposal
Thanks very much! |
Sure, I guess site publication are disabled right now. cats/scripts/travis-publish.sh Line 22 in 449e0b0
Therefore, in the meantime this publish should performed by hand in the same way until now ( https://github.com/typelevel/cats/blob/master/CONTRIBUTING.md#publishing-the-site-to-github I'm sorry about the sbt-microsites plugin documentation, it's still a WIP (actively working on it), nevertheless we hope to have ready all the plugin docs by this week. At the same time, we are working to have |
Ah that makes sense. Thanks! Is there a plan to release sbt-microsites? Looks very helpful. |
Yep, it'll be released very soon! On Sun, Sep 11, 2016, 2:22 PM Kai(luo) Wang [email protected]
|
@juanpedromoreno This looks very nice!! One thing that the cats docs do not currently do/have is support for current/previous versions - eg Had you thought about this as part of your new plugin? |
@BennyHill Not yet, but we'll do. Thanks! |
@juanpedromoreno I know your plugin is still WIP, 0.1.0 etc - I just thought I should pipe in with something that was on a TODO list at some point, lest it be forgotten. Looks cools already, btw 😸 |
Current coverage is 91.68% (diff: 100%)@@ master #1369 diff @@
==========================================
Files 240 240
Lines 3608 3608
Methods 3540 3540
Messages 0 0
Branches 67 67
==========================================
Hits 3308 3308
Misses 300 300
Partials 0 0
|
LGTM, I am wondering if we should wait for sbt-microsites release before merging this one in. |
👍 We're working in the |
Two small comments:
|
@jhzab For comment 1, potentially, it could be accomplished with For point 2, yep, you're right, compiling tut documents could take some time and memory (couple of GB of |
@juanpedromoreno thanks again. It looks like sbt-microsites has been released. I wonder if you have time to update this PR? Otherwise I can pick it up. |
Sure @kailuowang . I'll do it this afternoon. Thanks! |
@kailuowang Done ;) |
Looks like the 2.11 build was failing, not sure why, I've restarted it. |
It's green now, thanks @adelbertc |
👍 thanks a lot! |
Thanks a bunch, @juanpedromoreno! This looks really nice. I'm hoping I can find the time to take a closer look this evening or tomorrow. |
Hey @ceedubs @kailuowang, is there anything else I can do about this PR? Just let me know. Thanks! |
@juanpedromoreno LGTM. |
@juanpedromoreno I'm sorry for the long delay on this. Life has gotten busy. I won't get a chance to look at this in the next several days. It looks like @kailuowang already gave a 👍. @adelbertc or @tpolecat (or anyone else) would you want to review this? |
Sure, no problem @ceedubs |
addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.2.11") | ||
addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "0.8.0") | ||
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "1.2.0") | ||
addSbtPlugin("com.typesafe.sbt" % "sbt-git" % "0.8.5") | ||
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.11") | ||
addSbtPlugin("com.github.tkawachi" % "sbt-doctest" % "0.4.1") | ||
addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "1.1") | ||
addSbtPlugin("com.fortysevendeg" % "sbt-microsites" % "0.2.4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.2.5 now
I have approximately negative web dev experience but I looked at the changes and looks OK to me? 👍 from me. |
Thanks @adelbertc merging with two thumbs up. |
@juanpedromoreno @kailuowang How do we get this published on typelevel.org/cats ? |
@adelbertc @kailuowang Any person with permission to push to gh-pages branch simply could do:
That's it ;) |
I can give it a try, will ask in gitter room first. |
Published! Many thanks again @juanpedromoreno |
I noticed that it generates a new file docs/src/main/tut/contributing.md |
@kailuowang You can commit it or ignore it. It's copied (from the project root to the docs module) each time the microsite is built. The plugin needs to copy it for the tut compile phase (potentially contributing.md hasn't scala code, but the setting is generic for any kind of markdown file :/ ). |
This PR brings a new proposal for the Typelevel Cats website microsite.
It's made thanks to the https://github.com/47deg/sbt-microsites plugin and:
override.css
file and the images resources.The generated site has been removed since is not needed from now on. As you can see in the contributing.md file, the
site
can be generated each time on the fly.If you want to test locally you need Jekyll locally, depending on your platform, you might do this with:
Once you have installed it, you could perform the following steps:
docs/target/site
jekyll serve
Please, review at your convenience. Thanks!
Join-effort from the 47Deg team :)