Use friendly name in POM for published artifacts - fixes #1396 #1426
Conversation
| @@ -274,7 +274,7 @@ lazy val lawsJS = laws.js | |||
|
|
|||
| lazy val free = crossProject.crossType(CrossType.Pure) | |||
| .dependsOn(macros, core, tests % "test-internal -> test") | |||
| .settings(moduleName := "cats-free") | |||
| .settings(moduleName := "cats-free", name := "Cats Free") | |||
There was a problem hiding this comment.
Any reason "Free" is capitalized here (unlike the others)?
There was a problem hiding this comment.
I just did it because it was named after the Free monad which I usually see capitalized. I can make it lower case if folks prefer that.
There was a problem hiding this comment.
Fair enough. I don't have a strong opinion either way (but would prefer lowercase).
|
let's see what the community build thinks: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/853/consoleFull (404 til Jenkins catches up) |
community build run is green, so this LGTM |
|
@SethTisue Awesome possum @travisbrown Is that a 👍 from you or would you prefer I change the capitalization? |
|
Sure, as it is is fine. 👍 |
|
Seems reasonable to me. Thanks @adelbertc! 👍 |
Current coverage is 92.19% (diff: 100%)@@ master #1426 diff @@
==========================================
Files 242 242
Lines 3588 3588
Methods 3519 3519
Messages 0 0
Branches 69 69
==========================================
Hits 3308 3308
Misses 280 280
Partials 0 0
|
Similar fix (typelevel/cats#1426) and issue (typelevel/cats#1396) to Cats.
cc @SethTisue @BennyHill @travisbrown