Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use friendly name in POM for published artifacts - fixes #1396 #1426

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

adelbertc
Copy link
Contributor

@adelbertc adelbertc commented Oct 25, 2016

@@ -274,7 +274,7 @@ lazy val lawsJS = laws.js

lazy val free = crossProject.crossType(CrossType.Pure)
.dependsOn(macros, core, tests % "test-internal -> test")
.settings(moduleName := "cats-free")
.settings(moduleName := "cats-free", name := "Cats Free")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason "Free" is capitalized here (unlike the others)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did it because it was named after the Free monad which I usually see capitalized. I can make it lower case if folks prefer that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I don't have a strong opinion either way (but would prefer lowercase).

@SethTisue
Copy link
Member

let's see what the community build thinks: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/853/consoleFull (404 til Jenkins catches up)

@SethTisue
Copy link
Member

[cats] Resolving: https://github.com/adelbertc/cats.git#4522b6117574d24c41ce870a72ffc8257afd2e67 ...
...
[info] Project cats--------------------: SUCCESS (project rebuilt ok)

community build run is green, so this LGTM

@adelbertc
Copy link
Contributor Author

@SethTisue Awesome possum

@travisbrown Is that a 👍 from you or would you prefer I change the capitalization?

@travisbrown
Copy link
Contributor

Sure, as it is is fine. 👍

@non
Copy link
Contributor

non commented Oct 25, 2016

Seems reasonable to me. Thanks @adelbertc! 👍

@codecov-io
Copy link

codecov-io commented Oct 25, 2016

Current coverage is 92.19% (diff: 100%)

Merging #1426 into master will not change coverage

@@             master      #1426   diff @@
==========================================
  Files           242        242          
  Lines          3588       3588          
  Methods        3519       3519          
  Messages          0          0          
  Branches         69         69          
==========================================
  Hits           3308       3308          
  Misses          280        280          
  Partials          0          0          

Powered by Codecov. Last update 6b07ff7...4522b61

@adelbertc adelbertc merged commit 93a4d6a into typelevel:master Oct 25, 2016
@stew stew removed the in progress label Oct 25, 2016
adelbertc added a commit to adelbertc/circe that referenced this pull request Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants