A few more Either FAQ details #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2016
Merged
|
@philwills I just merged in your change—let me know if this looks okay to you and we can close #1429. |
peterneyens
reviewed
Oct 25, 2016
| @@ -40,9 +40,12 @@ a bunch of useful combinators around it. In Scala 2.12.x `Either` | |||
| `scala.util.Either` and fill in the gaps via | |||
| [syntax enrichment](https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/syntax/either.scala). | |||
|
|
|||
| This syntax can be imported via `cats.syntax.either._` or through `cats.implicits._`. | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Thanks again @peterneyens—I'm clearly in too much of a rush here. :)
I've also swapped the order to fit with the preferred order as suggested on the imports page and fixed the link to that.
travisbrown
force-pushed
the
topic/either-clarifications
branch
from
ce7917a
to
c0a19ad
Compare
|
👍 |
1 similar comment
|
👍 |
|
👍 looks perfect to me. |
Current coverage is 92.20% (diff: 100%)@@ master #1430 diff @@
==========================================
Files 242 242
Lines 3606 3606
Methods 3537 3537
Messages 0 0
Branches 69 69
==========================================
Hits 3325 3325
Misses 281 281
Partials 0 0
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to @philwills's comment on #1412.