-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few more Either FAQ details #1430
A few more Either FAQ details #1430
Conversation
@philwills I just merged in your change—let me know if this looks okay to you and we can close #1429. |
@@ -40,9 +40,12 @@ a bunch of useful combinators around it. In Scala 2.12.x `Either` | |||
`scala.util.Either` and fill in the gaps via | |||
[syntax enrichment](https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/syntax/either.scala). | |||
|
|||
This syntax can be imported via `cats.syntax.either._` or through `cats.implicits._`. | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed something 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @peterneyens—I'm clearly in too much of a rush here. :)
I've also swapped the order to fit with the preferred order as suggested on the imports page and fixed the link to that.
ce7917a
to
c0a19ad
Compare
👍 |
1 similar comment
👍 |
👍 looks perfect to me. |
Current coverage is 92.20% (diff: 100%)@@ master #1430 diff @@
==========================================
Files 242 242
Lines 3606 3606
Methods 3537 3537
Messages 0 0
Branches 69 69
==========================================
Hits 3325 3325
Misses 281 281
Partials 0 0
|
👍 |
In response to @philwills's comment on #1412.