-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using regular syntax in the FreeApplicative tutorial (#1471) #1472
Using regular syntax in the FreeApplicative tutorial (#1471) #1472
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1472 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 240 240
Lines 3947 3947
Branches 137 137
=======================================
Hits 3684 3684
Misses 263 263 Continue to review full report at Codecov.
|
Thanks @denisftw 👍 |
I think it makes sense to use the regular syntax in the example. But polymorphic lambdas was very handy in such situations. And if I remember correctly, such application in Free was one of the incentives of introducing polymorphic lambda in kind projector. We also use it in cats code. It might be worthwhile to mention polymorphic lambda here and use one of the
@denisftw @peterneyens what do you guys think? |
It is indeed a good idea to mention the polymorphic lambda syntax and include such an example. We could probably also add something about the polymorphic lambda syntax to the section about kind projector in the FAQ. |
Sounds good to me. 👍 |
This one fell through the cracks. I'm +1 on what has been said:
|
Thanks @denisftw! I really like this change. I'm sorry that it fell between the cracks. I'm 👍 on merging this, and there are now Unfortunately, there is a merge conflict. Would you want to resolve that? If not, I can take your work and turn it into a new PR. |
Sure, I'll take a look tomorrow. |
Thanks @denisftw! |
As suggested in #1471, this PR adjusts examples in the FreeApplicative tutorial to use regular syntax instead of kind projector's lambdas.