-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-constant arbitrary functions for (Co)Kleisli, State, Func #1619
Conversation
Resolves typelevel#1605. This is a replacement for typelevel#1606.
Requesting a review from @non. As you are the one who introduced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Curious about @non's input.
Oops there's a compile error in the free module. I'll fix it. |
@edmundnoble hmm actually I guess this compile error is one potential reason to favor the direct Now I'm second-guessing this approach :\ |
Huh. I can't see why that'd be the case, the implicit error that is. TBH I am more inclined toward the argument in the other direction; users can provide their own |
@edmundnoble hmm I guess that the implicit divergence only is happening in the scala.js build:
And yeah you are right, it is reporting a problem with the Kleisli Monoid. That's concerning. I'll try to take a look at this this evening (Eastern US time). |
Resolves typelevel#1605. This is a replacement for typelevel#1619. The approach taken in that PR led to implicit resolution failures in scala.js.
Closing in favor of #1666. @edmundnoble sorry I'm departing from your preferred approach, but I seem to need to in order for this to compile in the scala.js build 😬 |
Resolves #1605.
This is a replacement for #1606.
Now that
Arbitrary
instances for functions have been improved with the introduction ofCogen
in scalacheck, we can pick up better arbitrary functions than the constant ones we were using.