Make simulacrum a compile time only dependency #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice trick! 👍 on build green |
|
Oh nice. @mpilquist does this look good to you? |
|
Yes definitely, this has been on my list of things to mention for over a year but I kept forgetting. :) |
mpilquist
approved these changes
Apr 28, 2017
Codecov Report
@@ Coverage Diff @@
## master #1638 +/- ##
=======================================
Coverage 93.37% 93.37%
=======================================
Files 240 240
Lines 3941 3941
Branches 144 144
=======================================
Hits 3680 3680
Misses 261 261Continue to review full report at Codecov.
|
ceedubs
approved these changes
Apr 28, 2017
|
Thanks @peterneyens and @yilinwei! |
|
Discussion about more direct support for this in SBT here. Issue here: sbt/sbt#2503. |
fthomas
added a commit
to fthomas/cats
that referenced
this pull request
Sep 2, 2017
This is another change that makes upgrading to sbt 1.0 easier
and which is compatible with sbt 0.13.
With sbt 1.0 the following line in `commonSettings`:
```
ivyConfigurations += config("compile-time").hide
```
leads to this exception:
```
[info] Loading settings from build.sbt,version.sbt ...
[info] Resolving key references (15580 settings) ...
[error] java.lang.IllegalArgumentException: requirement failed: id must be capitalized: commonSettings
[error] at scala.Predef$.require(Predef.scala:277)
[error] at sbt.librarymanagement.Configuration.<init>(Configuration.scala:19)
[error] at sbt.librarymanagement.Configuration$.of(Configuration.scala:72)
[error] at $61255add5b0123fd7403$.$anonfun$commonSettings$9(build.sbt:47)
```
The reason why `commonSettings` is used as `id` for this "compile-time"
configuration can be found in [this sbt-librarymanagement macro](https://github.com/sbt/librarymanagement/blob/53c80f076a5e9ab469037f352a4d68173140e216/core/src/main/scala/sbt/librarymanagement/ConfigurationExtra.scala#L109-L114).
As the macro suggests, extracting the defintion of the `Configuration`
and assigning it to a `val` fixes the error.
The "compile-time" configuration was added in
typelevel#1638 to remove simulacrum from
the dependencies in the POM. I therefore checked that simulacrum is
still not present in the POM after this change.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yilinwei mentioned on the gitter channel that we could change the simulacrum dependency to be compile time only.