Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promoting the ecosystem in readme a bit and fixed a typo #1781

Merged
merged 5 commits into from
Aug 5, 2017

Conversation

kailuowang
Copy link
Contributor

@kailuowang kailuowang commented Aug 4, 2017

also updated cats-mtl url

@milessabin
Copy link
Member

milessabin commented Aug 4, 2017

I suggest changing "Generic libraries to support pure functional programming" to "General purpose libraries to support pure functional programming".

@codecov-io
Copy link

codecov-io commented Aug 4, 2017

Codecov Report

Merging #1781 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1781   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files         241      241           
  Lines        4139     4139           
  Branches      103      104    +1     
=======================================
  Hits         3927     3927           
  Misses        212      212

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22afeac...a40c969. Read the comment docs.

@kailuowang
Copy link
Contributor Author

thanks @milessabin ,updated

@@ -98,7 +98,7 @@ Many projects integrate with cats. By sharing the same set of
type classes, instances and data types, projects can speak the same "cats
language", and integrate with each other with ease.

#### Generic libraries to support pure functional programming
#### General purpose libraries to support pure functional programming

* [Mouse](https://github.com/benhutchison/mouse): a small companion to cats that provides convenient syntax (aka extension methods)
Copy link
Contributor

@andyscott andyscott Aug 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mouse can be removed from this list, as it's listed above in the index file as one of the cats extra modules. Also, it's not on this list in the primary README anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed.

@johnynek
Copy link
Contributor

johnynek commented Aug 5, 2017

👍

@kailuowang kailuowang merged commit 0519906 into typelevel:master Aug 5, 2017
@kailuowang kailuowang deleted the minor-update branch August 5, 2017 18:58
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants