Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pureconfig and finch to ecosystem project list #1873

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

kailuowang
Copy link
Contributor

approval acquired at pureconfig/pureconfig#298 and finagle/finch#818

@@ -110,6 +110,9 @@ language", and integrate with each other with ease.
* [decline](https://github.com/bkirwi/decline): A composable command-line parser
* [seals](https://github.com/durban/seals): tools for schema evolution and language-integrated schemata
* [grafter](https://github.com/zalando/grafter): dependency-injection library using the `Reader` pattern
* [finch](https://github.com/finagle/finch): Scala combinator library for building Finagle HTTP services
* [pureconfig](https://github.com/pureconfig/pureconfig): A boilerplate-free library for loading configuration files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to make a difference between libraries which use cats and those which provide an -cats extension like pureconfig and frameless (and refined, typelevel/paiges, ...) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a "through -cats extension" note might be useful. Just wasn't sure how important it is to justify the time (also those may subject to change).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way can we address those in a different PR?

@codecov-io
Copy link

codecov-io commented Aug 29, 2017

Codecov Report

Merging #1873 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1873   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files         241      241           
  Lines        4193     4193           
  Branches      115      115           
=======================================
  Hits         3982     3982           
  Misses        211      211

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf9338...28d2177. Read the comment docs.

@kailuowang kailuowang merged commit 14d9c10 into master Aug 30, 2017
LukaJCB pushed a commit to LukaJCB/cats that referenced this pull request Sep 1, 2017
@kailuowang kailuowang deleted the kailuowang-patch-1 branch October 10, 2017 18:44
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants