Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in SemigroupK scaladoc #1875

Merged
merged 2 commits into from
Sep 1, 2017

Conversation

LukaJCB
Copy link
Member

@LukaJCB LukaJCB commented Aug 30, 2017

No description provided.

@kailuowang
Copy link
Contributor

not a native speaker, but according to dictionary, both valid spelling of the word?

@johnynek
Copy link
Contributor

seems both are legit, but this change moves to the more common usage on mathscinet (but only a 2 to 1 ratio):

https://english.stackexchange.com/questions/79847/parametrise-or-parameterise-a-curve

fine with me to make the change.

👍

@fthomas
Copy link
Member

fthomas commented Aug 30, 2017

If we do this, we should change all occurrences of "parameterized":
https://github.com/typelevel/cats/search?utf8=%E2%9C%93&q=parameterized

@codecov-io
Copy link

codecov-io commented Aug 30, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@406d984). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1875   +/-   ##
=========================================
  Coverage          ?   94.97%           
=========================================
  Files             ?      241           
  Lines             ?     4195           
  Branches          ?      109           
=========================================
  Hits              ?     3984           
  Misses            ?      211           
  Partials          ?        0
Impacted Files Coverage Δ
core/src/main/scala/cats/MonoidK.scala 80% <ø> (ø)
core/src/main/scala/cats/SemigroupK.scala 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406d984...714d5aa. Read the comment docs.

@LukaJCB
Copy link
Member Author

LukaJCB commented Aug 30, 2017

Huh, didn't know both versions are valid, TIL 😄
I'll go ahead and change the other occurrences

@johnynek
Copy link
Contributor

johnynek commented Sep 1, 2017

👍

@kailuowang kailuowang merged commit 3124534 into typelevel:master Sep 1, 2017
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants