-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give higher priority to partial-unification fix #1946
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1946 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 248 248
Lines 4454 4454
Branches 117 117
=======================================
Hits 4257 4257
Misses 197 197 Continue to review full report at Codecov.
|
This is an improvement but I think I would probably still miss it ... when I look at a README like this I tend to gloss over everything other than the code blocks. Don't know if anyone else does this. I think I would be more likely to notice something like
|
Good idea @tpolecat |
Thanks @tpolecat, I definitely agree with your suggestion! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
After answering questions about relating to partial-unification, I think we should reprioritize its standing in the Readme.md. This PR mentions the fix up front instead of a side-note further down below. WDYT? :)