Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do redirect to look into cats-mtl for MonadCombine #2035

Merged
merged 1 commit into from
Nov 24, 2017

Conversation

vendethiel
Copy link
Contributor

@vendethiel vendethiel commented Nov 22, 2017

...Because it's not there. @LukaJCB++ on gitter pointed out that the use cases for MonadCombine are handled using Alternative or Monad + MonoidK now.

Note: it appears there's a MonadCombineSuite, which provides a test for a single method of Alternative. If I can get some time I'll rename it & add the missing tests.

@codecov-io
Copy link

codecov-io commented Nov 22, 2017

Codecov Report

Merging #2035 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2035   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files         305      305           
  Lines        5179     5179           
  Branches      127      126    -1     
=======================================
  Hits         4933     4933           
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9020258...211e7d4. Read the comment docs.

CHANGES.md Outdated
@@ -205,7 +205,8 @@ as many breaking changes as possible in this release before we lock down the API
* All `Unapply` enabled methods, e.g. `sequenceU`, `traverseU`, etc. are removed. `Unapply`
enabled syntax ops are also removed. Please use the partial unification SI-2712 fix
instead. The easiest way might be this [sbt-plugin](https://github.com/fiadliel/sbt-partial-unification).
* `FunctorFilter`, `MonadCombine`, `MonadFilter`, `MonadReader`, `MonadState`, `MonadTrans`, `MonadWriter` and `TraverseFilter` are no longer in `cats`, the functionalities they provided are inherited by the new [cats-mtl](https://github.com/typelevel/cats-mtl) project. Please check [here](https://github.com/typelevel/cats-mtl#migration-guide) for migration guide.
* `FunctorFilter`, `MonadFilter`, `MonadReader`, `MonadState`, `MonadTrans`, `MonadWriter` and `TraverseFilter` are no longer in `cats`, the functionalities they provided are inherited by the new [cats-mtl](https://github.com/typelevel/cats-mtl) project. Please check [here](https://github.com/typelevel/cats-mtl#migration-guide) for migration guide.
* `MonadCombine` is no longer in cats. Use `Alternative` or `Monad` + `K` instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouls say MonoidK :)

@vendethiel
Copy link
Contributor Author

Done :-).

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@LukaJCB LukaJCB merged commit 84376b0 into typelevel:master Nov 24, 2017
@kailuowang kailuowang added this to the 1.0.0 milestone Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants