Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jump start guide #2178

Merged
merged 5 commits into from
May 18, 2018
Merged

Add jump start guide #2178

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40ab9ac
Add jump start guide (#1017)
PawelLipski Mar 1, 2018
ea19c1a
Adapt the guide to Cats version 1.0.1
PawelLipski Mar 17, 2018
8844109
Fix blog style and formatting
PawelLipski Apr 6, 2018
f043d03
Remove references to mocks
PawelLipski Apr 27, 2018
610346e
Link guide from FAQ instead of main menu
PawelLipski May 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ lazy val includeGeneratedSrc: Setting[_] = {
lazy val catsSettings = commonSettings ++ publishSettings ++ scoverageSettings ++ javadocSettings

lazy val scalaCheckVersion = "1.13.5"
lazy val scalaMockVersion = "3.6.0"
Copy link
Contributor

@Andrea Andrea Apr 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me that finds mocks (in a functional context) a bit of a flag for things that could be improved? I can see why you are adding this here, at the same time...I have reservations for the same reason the Future was mentioned in another comment.
If it was me, I would go with a simplified implementation for the purposes of this example (this is why I was re writing a lot of the examples)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree, I think Future is good as a gateway drug, but I'm not sure we should encourage mocks. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, fixing now

// 2.13.0-M3 workaround
//lazy val scalaTestVersion = "3.0.5"
lazy val disciplineVersion = "0.9.0"
Expand Down Expand Up @@ -183,6 +184,7 @@ lazy val docSettings = Seq(
"gray-light" -> "#E5E5E6",
"gray-lighter" -> "#F4F3F4",
"white-color" -> "#FFFFFF"),
libraryDependencies ++= Seq("org.scalamock" %% "scalamock-scalatest-support" % scalaMockVersion),
autoAPIMappings := true,
unidocProjectFilter in (ScalaUnidoc, unidoc) :=
inProjects(docsSourcesAndProjects(scalaVersion.value)._2:_*),
Expand Down
Loading