Added commutative apply and applicative to Const #2204
Conversation
|
Insufficient memory, but the changes should pass tests and MiMa |
|
Could it be possible to run the CI on this again ? Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #2204 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 333 333
Lines 5789 5789
Branches 222 211 -11
=======================================
Hits 5490 5490
Misses 299 299
Continue to review full report at Codecov.
|
|
|
||
| { | ||
| implicit val setMonoid: CommutativeMonoid[Int] = |
There was a problem hiding this comment.
Should we name this intCommutativeMonoid instead, maybe?
There was a problem hiding this comment.
ops ... fixing it 👍
|
|
||
| { | ||
| implicit val setMonoid: CommutativeSemigroup[Int] = |
There was a problem hiding this comment.
fixing this as well, thanks
|
|
||
| { | ||
| implicit val intCommutativeMonoid: CommutativeMonoid[Int] = |
There was a problem hiding this comment.
Instead of defining this instance just for this test, I think that you should be able to use CMono from Helpers.scala. You can see an example of it being used in FunctionSuite.scala. Similarly for the commutative semigroup below (CSemi).
There was a problem hiding this comment.
sure, I will change it 👍
|
|
||
| { | ||
| implicit val iso = SemigroupalTests.Isomorphisms.invariant[Const[CSemi, ?]](Const.catsDataFunctorForConst) |
There was a problem hiding this comment.
obviously not 😄 . Thanks for this review. It's amazing to have your help.
There was a problem hiding this comment.
I can't understand where the Invariant[Const[CSemi, ?]] comes from though. If is not too long, could you explain me why I have in scope that one but not Invariant[Const[CMono, ?]] ? Thanks
There was a problem hiding this comment.
To be honest I'm not familiar with why these SemigroupalTests.Isomorphism.invariants are needed in some tests. Maybe someone else can provide insight there. I wasn't sure why it was needed so I tried removing it in both cases and one of them still compiled ¯\_(ツ)_/¯
|
Thanks a lot, @barambani! One minor remaining question and then this looks good to me. |
|
I will fix it. Thank you for the time you spend on this. 👍 |
|
Thank you both 😄 |
This addresses the issue #2201