-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an explanation for the missing Applicative instances for monad transformers #2277
Add an explanation for the missing Applicative instances for monad transformers #2277
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2277 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 364 364
Lines 6707 6707
Branches 285 301 +16
=======================================
Hits 6380 6380
Misses 327 327 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I like it, but can we extract a bit from the issue you linked, I feel like just linking to an issue will cause people to have to wade through a bunch of discussion instead of getting to the actual point. You know what I mean? 🤔 |
Sure, I'll look for something that can be there instead of the link. |
Can we just drop the link? The potential inconsistency is already mentioned. WDYT? |
I think that might be more confusing, then it'd just say "This is inconsistent" without naming a good reason. |
Maybe add the counter example noted here? #1106 (comment) Of course would need porting to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I agree it would be better to extract the content from the linked ticket.
@easel I haven't had much time to work on this recently, but I'll surely extract something before I consider this good to merge :P |
@LukaJCB as part of this week's goal to finish up all open OSS PRs, I updated this one - please take a look :) |
@kailuowang FYI |
Thanks very much @kubukoz ! |
Closes #2272.
Just a few lines to start with, hope you have some feedback on what else I can mention/what can be reworded :)