Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FunctorFilter and TraverseFilter #2405

Merged
merged 15 commits into from
Sep 3, 2018
Merged

Commits on Aug 15, 2018

  1. Add FunctorEmpty and TraverseEmpty

    Luka Jacobowitz committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    9c9d9de View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2018

  1. Merge branch 'master' into filter-classes

    Luka Jacobowitz authored and Luka Jacobowitz committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    f97ba06 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into filter-classes

    Luka Jacobowitz authored and Luka Jacobowitz committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    4810a9f View commit details
    Browse the repository at this point in the history
  3. Add TraverseEmpty instance for Chain

    Luka Jacobowitz committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    d77ab2a View commit details
    Browse the repository at this point in the history
  4. Merge branch 'filter-classes' of https://github.com/LukaJCB/cats into…

    … filter-classes
    Luka Jacobowitz committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    54903f6 View commit details
    Browse the repository at this point in the history
  5. Make TraverseEmpty[Chain] serializable

    I think that the issue here is that it was referencing an instance-level
    `catsDataInstancesForChain` from an abstract class. By changing it to
    reference `Chain.catsDataInstancesForChain`, it is a reference to a
    static member (and therefore doesn't actually need to be serialized).
    
    Take my explanation with a grain of salt -- like everyone else on the
    planet, I don't actually understand Java serialization. But at the end
    of the day it works :)
    ceedubs committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    218c4c9 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #4 from ceedubs/fix-chain-traverse-empty-ctcization

    Make TraverseEmpty[Chain] serializable
    Luka Jacobowitz authored Aug 16, 2018
    Configuration menu
    Copy the full SHA
    344810e View commit details
    Browse the repository at this point in the history
  7. Merge branch 'master' into filter-classes

    Luka Jacobowitz authored Aug 16, 2018
    Configuration menu
    Copy the full SHA
    b9e337a View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2018

  1. Remove conversion to mainline classes

    Luka Jacobowitz committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    a3f0d26 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2018

  1. Add traverseFilter <-> traverse consistency law

    Luka Jacobowitz committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    d323da2 View commit details
    Browse the repository at this point in the history
  2. Make Functor override final

    Luka Jacobowitz committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    8255d59 View commit details
    Browse the repository at this point in the history
  3. Rename Functor and Traverse Empty to Filter

    Luka Jacobowitz committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    bf07dd3 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2018

  1. Merge branch 'master' into filter-classes

    Luka Jacobowitz authored and Luka Jacobowitz committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    716d701 View commit details
    Browse the repository at this point in the history
  2. Add Nested FunctorFilter instance

    Luka Jacobowitz committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    46f2307 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2018

  1. Address feedback

    Luka Jacobowitz committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    b4c5080 View commit details
    Browse the repository at this point in the history