-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NestedIdOps.value leaking to types of shapes F[G[A]]
#2423
Fix NestedIdOps.value leaking to types of shapes F[G[A]]
#2423
Conversation
@kailuowang Should I have changed that to If I'm reading this right, it avoids binary incompatibility? |
Sounds a good plan. |
This prevents 'value' from leaking into types with shape `F[G[A]]`.
Codecov Report
@@ Coverage Diff @@
## master #2423 +/- ##
=======================================
Coverage 95.27% 95.27%
=======================================
Files 351 351
Lines 6350 6350
Branches 274 274
=======================================
Hits 6050 6050
Misses 300 300
Continue to review full report at Codecov.
|
@kailuowang I've fixed the binary compatibility issue, mind removing the label? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM.
Ideally we'd eventually want this to be changed back from package-private to private, wouldn't we? I'm wondering whether we should have a formal process for decluttering the noise that we add for binary compatibility (once we get to the point that we want to make a binary-incompatible release).
The `.value` removals are probablye due to typelevel/cats#2423
The `.value` removals are probably due to typelevel/cats#2423
2066: Bump cats r=ArturGajowy a=ArturGajowy The `.value` removals are probablye due to typelevel/cats#2423 Co-authored-by: Artur Gajowy <[email protected]>
Made 'value' private in
NestedIdOps
This prevents 'value' from leaking into types with shape
F[G[A]]
.I encountered this issue while using Scalatests
OptionValues
on things with aG[A]
shape, so I had aOption[G[A]]
and tried to use.value
. It caused an ambiguous implicit match withNestedIdOps
.I didn't add a test, because I didn't know where it should go. Would
SyntaxSuite.testNested
be an appropriate place?