Optimize the foldM implementation for Vector #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've also added a benchmark to compare the new implementation with the old. Here are the results that I got on my computer when running `bench/jmh:run -i 10 -wi 10 -f1 -t1 .*FoldBench\.vector.*`: ``` Benchmark Mode Cnt Score Error Units FoldBench.vectorIndexFoldM thrpt 10 1185138.829 ± 45633.259 ops/s FoldBench.vectorToListFoldM thrpt 10 817330.438 ± 21998.851 ops/s ```
kailuowang
approved these changes
Oct 4, 2018
Codecov Report
@@ Coverage Diff @@
## master #2552 +/- ##
==========================================
+ Coverage 95.17% 95.18% +<.01%
==========================================
Files 359 359
Lines 6555 6558 +3
Branches 273 285 +12
==========================================
+ Hits 6239 6242 +3
Misses 316 316
Continue to review full report at Codecov.
|
|
Nice work, thanks @ceedubs! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added a benchmark to compare the new implementation with the
old. Here are the results that I got on my computer when running
bench/jmh:run -i 10 -wi 10 -f1 -t1 .*FoldBench\.vector.*: