added a prePR command and PR template to remind people to run it #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2583 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 361 361
Lines 6634 6634
Branches 294 294
=======================================
Hits 6312 6312
Misses 322 322Continue to review full report at Codecov.
|
ceedubs
reviewed
Oct 25, 2018
ceedubs
reviewed
Oct 25, 2018
| @@ -697,6 +697,8 @@ addCommandAlias("validateKernelJS", "kernelLawsJS/test") | |||
| addCommandAlias("validateFreeJS", "freeJS/test") //separated due to memory constraint on travis | |||
| addCommandAlias("validate", ";clean;validateJS;validateKernelJS;validateFreeJS;validateJVM") | |||
|
|
|||
| addCommandAlias("prePR", ";fmt;validateBC") | |||
There was a problem hiding this comment.
I think that this is fine for now, but in the near future I'd like us to get to a branching setup where binary-incompatible changes are okay for the right branches or something.
There was a problem hiding this comment.
@ceedubs yes. It's probably possible that validateBC would just mean different thing on different branch or something.
ceedubs
previously approved these changes
Oct 25, 2018
Co-Authored-By: kailuowang <[email protected]>
kailuowang
dismissed stale reviews from ceedubs, olafurpg, and LukaJCB
via
73c6f21
LukaJCB
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.