-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated to 2.13-M5 #2589
updated to 2.13-M5 #2589
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2589 +/- ##
==========================================
+ Coverage 94.9% 95.17% +0.26%
==========================================
Files 361 361
Lines 6615 6653 +38
Branches 277 293 +16
==========================================
+ Hits 6278 6332 +54
+ Misses 337 321 -16
Continue to review full report at Codecov.
|
+1, this is on the path for |
Looks like some sort of scalatest or scalactic bug. |
at a glance, all that spew in the log looks like scalatest/scalatest#1423, but I think the actual failure is something else? |
The previous error was fixed, now I have a randomly occurring error (roughly 50% of the time) on scalajs
|
log spew might be a problem unto itself here? |
Minimized scalajs error example here |
turns out to be a |
can it be worked around for now? |
@SethTisue the scala.util.Failure regression can probably be circumvented by disabling the test on 2.13 temporarily. I am not sure about the scalatest output one. I'll poke around scalatest settings. |
just one test failing for (2.13, js_build false) in
|
looks like typelevel/scalacheck#427 (comment) / scala/scala-dev#562 |
the fix to this one is to turn |
can you just disable this single test using |
I'd like to turn |
I'm mostly just curious, but how come it isn't better to just crank up |
@SethTisue good question! Due to the need to generate coverage report, we need to run test from root module and congregate coverage reports (although that may be hackable). Since each test run classloader is not garbage collected, it's probably better memory wise that each module's test is run in a fresh forked jvm. |
🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thank you, @kailuowang and everyone else who helped make this happen!
@@ -17,7 +17,11 @@ class TrySuite extends CatsSuite { | |||
checkAll("Try[Int]", CoflatMapTests[Try].coflatMap[Int, Int, Int]) | |||
checkAll("CoflatMap[Try]", SerializableTests.serializable(CoflatMap[Try])) | |||
|
|||
checkAll("Try with Throwable", MonadErrorTests[Try, Throwable].monadError[Int, Int, Int]) | |||
//temporarily disable this test due to scala.util.Failure regression https://github.com/scala/bug/issues/11242 | |||
if (BuildInfo.scalaVersion != "2.13.0-M5") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to open an issue in this repo to remind ourselves to remove this hack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done: #2601
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @erikerlandson
Hopefully we can merge this one quickly and publish 1.5