-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get FunctorFilter on par with the other MTL typeclasses #2594
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2594 +/- ##
==========================================
+ Coverage 95.16% 95.16% +<.01%
==========================================
Files 361 361
Lines 6634 6641 +7
Branches 294 301 +7
==========================================
+ Hits 6313 6320 +7
Misses 321 321
Continue to review full report at Codecov.
|
As from #2556 (comment) the PR is ready for review. |
Sorry for the misleading comment, it looks like EitherT needs one too 😅 |
Thanks @Baccata , very true. There are some other that are still missing it and there might be also some that need a |
@kailuowang , @LukaJCB do you have any bandwidth to have a look at this PR ? In case let me know if you'd like for me to add anything here. Thanks a lot. |
sorry for the late response. I will take a look Monday |
no worries. Many thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
👍 |
This adds
FunctorFilter
toKleisli
andIndexedStateT
as from the issue #2556 . As a side note I tried to reduce the requirements for theIndexedStateT
instance but I couldn't come up with anything that need less thanApplicative
andFlatMap
, so I kept the implementation in the issue that requiresMonad
(see below as an example)I'm happy to change it though if there's something less restrictive.
There is still some work to do about the comments at the bottom of the ticket that I'm still investigating. I need more details there.
Also I'm planning to open some follow up PRs to add instances of
TraverseFilter
as well toKleisli
andIndexedStateT
, and to add both to other transformers where they are still missing. Is it something that's needed ? Happy to stop if they are not a priority.