Add rethrowT method to EitherT
#2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2655 +/- ##
==========================================
+ Coverage 95.12% 95.13% +<.01%
==========================================
Files 363 365 +2
Lines 6704 6758 +54
Branches 289 297 +8
==========================================
+ Hits 6377 6429 +52
- Misses 327 329 +2
Continue to review full report at Codecov.
|
kubukoz
previously approved these changes
Jan 2, 2019
kailuowang
reviewed
Jan 3, 2019
| F.flatMap(fa) { a => | ||
| pf.andThen(F.raiseError[A]).applyOrElse(a, (_: A) => fa) | ||
| } | ||
| F.flatMap(fa)(pf.andThen(F.raiseError[A]).applyOrElse(_, (_: A) => fa)) |
There was a problem hiding this comment.
Maybe I am biased, but I think the original version is more readable.
There was a problem hiding this comment.
I'm not attached to this change - I made it to match the style of other utility methods, but I'm happy to revert it if the original version is preferred.
LukaJCB
approved these changes
Jan 9, 2019
kailuowang
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rethrowTmethod to EitherT: inverse ofApplicativeError#attemptT, analogous toMonadError#rethrowMonadErrorOps.rejectand refactor to one line