Add a defer factory method to ContT
#2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the existing `pure` function, but evaluation of the argument
is deferred.
This is useful for building a computation which calls its continuation
as the final step. Instead of writing:
```
ContT.apply { next =>
val x = foo()
val y = bar(x)
val z = baz(y)
next(z)
}
```
you can write:
```
ContT.defer {
val x = foo()
val y = bar(x)
baz(y)
}
```
LukaJCB
previously approved these changes
Jan 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #2696 +/- ##
==========================================
+ Coverage 95.15% 95.16% +<.01%
==========================================
Files 365 365
Lines 6774 6780 +6
Branches 297 296 -1
==========================================
+ Hits 6446 6452 +6
Misses 328 328
Continue to review full report at Codecov.
|
|
Thanks @cb372! Would you be willing to add a ScalaDoc description of the method and a unit test or two? One unit test that I think would be good is one that checks that the argument isn't eagerly evaluated. |
There's no need to use a DeferCont here.
kailuowang
approved these changes
Jan 29, 2019
LukaJCB
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #2677.
Similar to the existing
purefunction, but evaluation of the argument is deferred.This is useful for building a computation which calls its continuation as the final step. Instead of writing:
you can write:
Thank you for contributing to Cats!
This is a kind reminder to run
sbt prePRand commit the changed files, if any, before submitting.