Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define OptionT.mapFilter in terms of OptionT.subflatMap #2765

Merged

Conversation

morgen-peschke
Copy link
Contributor

fixes #2757

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-io
Copy link

Codecov Report

Merging #2765 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2765      +/-   ##
==========================================
+ Coverage   95.31%   95.34%   +0.02%     
==========================================
  Files         363      363              
  Lines        6785     6785              
  Branches      285      283       -2     
==========================================
+ Hits         6467     6469       +2     
+ Misses        318      316       -2
Impacted Files Coverage Δ
core/src/main/scala/cats/data/OptionT.scala 96.29% <100%> (ø) ⬆️
...rc/main/scala/cats/kernel/instances/function.scala 100% <0%> (+3.03%) ⬆️
testkit/src/main/scala/cats/tests/Helpers.scala 100% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a1339...3f19495. Read the comment docs.

@kailuowang kailuowang merged commit 9479ce5 into typelevel:master Mar 28, 2019
@morgen-peschke morgen-peschke deleted the cleanup/optiont-mapFilter branch March 28, 2019 16:38
@kailuowang kailuowang added this to the 2.0.0-M1 milestone Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should OptionT.mapFilter be implemented in terms of OptionT.subflatMap
4 participants