Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for a cats-1.6.x patch #2861

Merged
merged 4 commits into from
Jun 3, 2019

Commits on May 26, 2019

  1. Change MonadErrorOps#reject so it no longer runs effects twice (typel…

    …evel#2810)
    
    * Add regression test for MonadErrorOps bug
    
    * Change MonadErrorOps#reject so it no longer re-runs the effect it is called on. Fixes typelevel#2809
    Ben Plommer authored and rossabaker committed May 26, 2019
    Configuration menu
    Copy the full SHA
    3c783f6 View commit details
    Browse the repository at this point in the history
  2. Fix Order.max and Oder.min description comments (typelevel#2842)

    Changed description to better fit their implentation
    orvi authored and rossabaker committed May 26, 2019
    Configuration menu
    Copy the full SHA
    5d9fb7f View commit details
    Browse the repository at this point in the history
  3. Make WrappedMutableMapBase extend Serializable (typelevel#2784)

    We are running into Spark `Task not serializable` issues when a closure
    that executes on a Spark executor node involves a `Map` that is created
    via running `foldMap` on a `List`. This commit makes the
    `WrappedMutableMap` hierarchy extend `Serializable` and chex that the
    cerealization works (this test failed before extending `Serializable`).
    ceedubs authored and rossabaker committed May 26, 2019
    Configuration menu
    Copy the full SHA
    8822980 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b30c995 View commit details
    Browse the repository at this point in the history