Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comonad documentation #2888

Merged
merged 5 commits into from
Jun 24, 2019
Merged

Comonad documentation #2888

merged 5 commits into from
Jun 24, 2019

Conversation

justinhj
Copy link
Contributor

Added a document page for Comonads

@codecov-io
Copy link

codecov-io commented Jun 14, 2019

Codecov Report

Merging #2888 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2888   +/-   ##
======================================
  Coverage    94.2%   94.2%           
======================================
  Files         368     368           
  Lines        6949    6949           
  Branches      304     304           
======================================
  Hits         6546    6546           
  Misses        403     403

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ed0095...6c892f7. Read the comment docs.

LukaJCB
LukaJCB previously approved these changes Jun 14, 2019
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, thanks! I'm happy to accept this as is, but I also feel a practical example would go a long way :)

@justinhj
Copy link
Contributor Author

I’ll spend some time finding a good example. I see Runar has posted a lot about Comonads so there are his implementations of Conways game of life as well as a graph traversal but maybe that is a bit big for this context.

@justinhj
Copy link
Contributor Author

I've made the suggested corrections. I gave some thought to a motivating example. Perhaps it would be good to write a doc page for Store, the dual of State, and include an example of how that is useful, then link to it from the comonad page later.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kailuowang kailuowang merged commit a0896a2 into typelevel:master Jun 24, 2019
@justinhj justinhj deleted the comonad-doc branch July 27, 2019 05:39
@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Aug 2, 2019
@gatear gatear mentioned this pull request Dec 8, 2021
70 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants