Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validated doctest #3061

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Conversation

hamednourhani
Copy link
Contributor

Re: Issue #2479

Add more doctest to Validated methods:

  • fold
  • isValid
  • isInvalid
  • forearch
  • getOrElse
  • valueOr
  • exists
  • forall
  • orElse
  • findValid
  • toEither
  • toOption
  • toIor
  • toList
  • toValidatedNel
  • toValidatedNec
  • withEither
  • bimap
  • compare
  • ===
  • ap
  • product
  • map
  • leftMap
  • traverse
  • foldLeft
  • foldRight
  • andThen
  • combine
  • swap
  • merge

@codecov-io
Copy link

Codecov Report

Merging #3061 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3061      +/-   ##
==========================================
+ Coverage   93.46%   93.49%   +0.02%     
==========================================
  Files         368      368              
  Lines        6979     6979              
  Branches      184      184              
==========================================
+ Hits         6523     6525       +2     
+ Misses        456      454       -2
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Validated.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/validated.scala 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d07788...6c9f185. Read the comment docs.

@hamednourhani
Copy link
Contributor Author

@kailuowang can i know about the review process . also the process of adding pull requests to millstone. Thanks a lot. :)

@kailuowang
Copy link
Contributor

@hamednourhani I don't think we have formal process of PR review other than it usually requires 2 maintainer approvals before it can be merged. Cats maintainers are volunteers using their spare time for this endeavor. (we have a sustainability program that as of now it still lack enough funding to hire even one part-time maintainer.) As a result, the speed of PR reviewing is not very predictable. Sometimes pinging maintainers in the PR or soliciting review in cats' gitter chatters move things forward, as I myself have done countless times in the past.
Milestone assignments is mostly done by individual maintainers, the bulk of which happens during a release, when all unassigned merged PR will be assigned to the milestone representing the upcoming release. There are also PRs that maintainers have specific reasons to assign to certain milestones. Anyone can suggest a milestone assignment, but usually it's not necessary.

I hope that answers your question.

@hamednourhani
Copy link
Contributor Author

Thanks a lot @kailuowang for you reply.

@hamednourhani
Copy link
Contributor Author

@LukaJCB would you please review this PR.

@kailuowang kailuowang merged commit 94b88f0 into typelevel:master Sep 24, 2019
@travisbrown travisbrown modified the milestone: 2.1-RC1 Oct 28, 2019
@travisbrown
Copy link
Contributor

Sorry, accidentally hit the milestone button. 😄

@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants