-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validated doctest #3061
Validated doctest #3061
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3061 +/- ##
==========================================
+ Coverage 93.46% 93.49% +0.02%
==========================================
Files 368 368
Lines 6979 6979
Branches 184 184
==========================================
+ Hits 6523 6525 +2
+ Misses 456 454 -2
Continue to review full report at Codecov.
|
@kailuowang can i know about the review process . also the process of adding pull requests to millstone. Thanks a lot. :) |
@hamednourhani I don't think we have formal process of PR review other than it usually requires 2 maintainer approvals before it can be merged. Cats maintainers are volunteers using their spare time for this endeavor. (we have a sustainability program that as of now it still lack enough funding to hire even one part-time maintainer.) As a result, the speed of PR reviewing is not very predictable. Sometimes pinging maintainers in the PR or soliciting review in cats' gitter chatters move things forward, as I myself have done countless times in the past. I hope that answers your question. |
Thanks a lot @kailuowang for you reply. |
@LukaJCB would you please review this PR. |
Sorry, accidentally hit the milestone button. 😄 |
Re: Issue #2479
Add more doctest to Validated methods: