Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combineKEval and add short-circuiting for foldMapK #3446

Merged
merged 2 commits into from
May 31, 2020

Conversation

LukaJCB
Copy link
Member

@LukaJCB LukaJCB commented May 31, 2020

Will fix #2707

@travisbrown travisbrown self-requested a review May 31, 2020 13:39
travisbrown
travisbrown previously approved these changes May 31, 2020
Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me after formatting to fix the build.

@codecov-commenter
Copy link

Codecov Report

Merging #3446 into master will increase coverage by 0.00%.
The diff coverage is 83.29%.

@@           Coverage Diff           @@
##           master    #3446   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         381      381           
  Lines        8269     8299   +30     
  Branches      225      216    -9     
=======================================
+ Hits         7578     7606   +28     
- Misses        691      693    +2     

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks!

@travisbrown
Copy link
Contributor

Squashing since the second commit is just formatting.

@travisbrown travisbrown merged commit be306aa into master May 31, 2020
@LukaJCB LukaJCB deleted the combinek-eval branch May 31, 2020 18:46
@travisbrown travisbrown added this to the 2.2.0-M3 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a combineKEval method
4 participants