Rerun Simulacrum after rearrangement for Scala.js #3482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If that's the problem, isn't this change triggering it ? UPDATE: I just read the original issue. Clear now. 👍 |
|
@barambani Sorry, yes, I wrote "before" where I meant "after". I've edited the description. |
|
Hmm, the Simulacrum Scalafix release is on Sonatype Releases but doesn't seem to have synced to Maven Central yet. I'll try restarting the build a little later. |
|
Okay, this should be ready for review now. |
barambani
approved these changes
Jun 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #3482 +/- ##
==========================================
+ Coverage 91.77% 91.82% +0.04%
==========================================
Files 383 383
Lines 8394 8465 +71
Branches 205 205
==========================================
+ Hits 7704 7773 +69
- Misses 690 692 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this bug and the Simulacrum Scalafix workaround by @joroKr21 here. In short the problem is that defining a lowercase
opsafter the capitalizedOpstrait causes problems on Scala.js 1.x on some platforms. (This bug also affects the macro annotation implementation of Simulacrum.)This change uses the new 0.5.0 release of Simulacrum Scalafix I just published with that and one other fix (which doesn't affect Cats's usage).