-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enumerable (WIP) #4349
Draft
isomarcte
wants to merge
11
commits into
typelevel:main
Choose a base branch
from
isomarcte:to-from-enum
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Enumerable (WIP) #4349
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9debe1c
poc
isomarcte bbd6664
Cleanup comments, add LazyListCompat, add numeric step functions
isomarcte be74ffc
Add BoundlessEnumerable, nextOrMin, and previousOrMax
isomarcte 380ecd7
Add size to Enumerable
isomarcte c0432f8
Clarify Comment
isomarcte 9465aff
Typo In Comment
isomarcte ca66fcb
BigInt instance and initial pass at laws
isomarcte 208587d
More Enumerable Instances, Laws, And Docs
isomarcte 59510b2
Incomplete encoding of cycleForward functions
isomarcte 13380af
squash!
isomarcte c013788
squash!
isomarcte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
kernel/src/main/scala-2.12/cats/kernel/ScalaVersionSpecificLazyListCompat.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package cats | ||
package kernel | ||
|
||
private[kernel] object ScalaVersionSpecificLazyListCompat extends LazyListCompatBase { | ||
override final type T[A] = scala.collection.immutable.Stream[A] | ||
|
||
override final def apply[A](a: A*): T[A] = | ||
scala.collection.immutable.Stream.apply[A](a: _*) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
kernel/src/main/scala-2.13+/cats/kernel/ScalaVersionSpecificLazyListCompat.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package cats | ||
package kernel | ||
|
||
private[kernel] object ScalaVersionSpecificLazyListCompat extends LazyListCompatBase { | ||
override final type T[A] = scala.collection.immutable.LazyList[A] | ||
|
||
override final def apply[A](a: A*): T[A] = | ||
scala.collection.immutable.LazyList.apply[A](a: _*) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder, can we simply define a type alias Stream => LazyList for Scala 2.12,
while keeping a usual LazyList for Scala 2.13+ ?
or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably do that, but we'd be implying that all methods used would be identical for
Stream
andLazyList
. I think they are right now...and we could add exceptions if needed in the future...So...yes? I'll try it out.