Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enumerable (WIP) #4349

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Enumerable (WIP) #4349

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9debe1c
poc
isomarcte Nov 16, 2022
bbd6664
Cleanup comments, add LazyListCompat, add numeric step functions
isomarcte Nov 17, 2022
be74ffc
Add BoundlessEnumerable, nextOrMin, and previousOrMax
isomarcte Nov 17, 2022
380ecd7
Add size to Enumerable
isomarcte Nov 18, 2022
c0432f8
Clarify Comment
isomarcte Nov 18, 2022
9465aff
Typo In Comment
isomarcte Nov 18, 2022
ca66fcb
BigInt instance and initial pass at laws
isomarcte Nov 18, 2022
208587d
More Enumerable Instances, Laws, And Docs
isomarcte Nov 22, 2022
59510b2
Incomplete encoding of cycleForward functions
isomarcte Nov 22, 2022
13380af
squash!
isomarcte Nov 23, 2022
c013788
squash!
isomarcte Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions kernel/src/main/scala-2.12/cats/kernel/EnumerableCompat.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ package kernel
import scala.{specialized => sp}
import scala.collection.immutable.Stream

@deprecated(message = "Please use Enumerable instead.", since = "2.10.0")
trait PartialPreviousUpperBounded[@sp A] extends PartialPrevious[A] with PartialNext[A] with UpperBounded[A] {

/**
* Enumerate the members in descending order.
*/
@deprecated(message = "Please use Enumerable.membersDescending.", since = "2.10.0")
def membersDescending: Stream[A] = {
def loop(a: A): Stream[A] =
partialPrevious(a) match {
Expand All @@ -41,11 +43,13 @@ trait PartialPreviousUpperBounded[@sp A] extends PartialPrevious[A] with Partial

}

@deprecated(message = "Please use Enumerable instead.", since = "2.10.0")
trait PartialNextLowerBounded[@sp A] extends PartialPrevious[A] with PartialNext[A] with LowerBounded[A] {

/**
* Enumerate the members in ascending order.
*/
@deprecated(message = "Please use Enumerable.membersAscending.", since = "2.10.0")
def membersAscending: Stream[A] = {
def loop(a: A): Stream[A] =
partialNext(a) match {
Expand Down
9 changes: 9 additions & 0 deletions kernel/src/main/scala-2.12/cats/kernel/ScalaVersionSpecificLazyListCompat.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package cats
package kernel

private[kernel] object ScalaVersionSpecificLazyListCompat extends LazyListCompatBase {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, can we simply define a type alias Stream => LazyList for Scala 2.12,
while keeping a usual LazyList for Scala 2.13+ ?

type LazyList[a] => Stream[a]
val LazyList = Stream

or something like that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably do that, but we'd be implying that all methods used would be identical for Stream and LazyList. I think they are right now...and we could add exceptions if needed in the future...

So...yes? I'll try it out.

override final type T[A] = scala.collection.immutable.Stream[A]

override final def apply[A](a: A*): T[A] =
scala.collection.immutable.Stream.apply[A](a: _*)
}
4 changes: 4 additions & 0 deletions kernel/src/main/scala-2.13+/cats/kernel/EnumerableCompat.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ package kernel
import scala.{specialized => sp}
import scala.collection.immutable.LazyList

@deprecated(message = "Please use Enumerable", since = "2.10.0")
trait PartialPreviousUpperBounded[@sp A] extends PartialPrevious[A] with PartialNext[A] with UpperBounded[A] {

/**
* Enumerate the members in descending order.
*/
@deprecated(message = "Please use Enumerable.membersDescending.", since = "2.10.0")
def membersDescending: LazyList[A] = {
def loop(a: A): LazyList[A] =
partialPrevious(a) match {
Expand All @@ -41,11 +43,13 @@ trait PartialPreviousUpperBounded[@sp A] extends PartialPrevious[A] with Partial

}

@deprecated(message = "Please use Enumerable", since = "2.10.0")
trait PartialNextLowerBounded[@sp A] extends PartialPrevious[A] with PartialNext[A] with LowerBounded[A] {

/**
* Enumerate the members in ascending order.
*/
@deprecated(message = "Please use Enumerable.membersAscending.", since = "2.10.0")
def membersAscending: LazyList[A] = {
def loop(a: A): LazyList[A] =
partialNext(a) match {
Expand Down
9 changes: 9 additions & 0 deletions kernel/src/main/scala-2.13+/cats/kernel/ScalaVersionSpecificLazyListCompat.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package cats
package kernel

private[kernel] object ScalaVersionSpecificLazyListCompat extends LazyListCompatBase {
override final type T[A] = scala.collection.immutable.LazyList[A]

override final def apply[A](a: A*): T[A] =
scala.collection.immutable.LazyList.apply[A](a: _*)
}
Loading