Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two new laws for Bimonad. #596

Merged
merged 1 commit into from
Nov 3, 2015
Merged

Add two new laws for Bimonad. #596

merged 1 commit into from
Nov 3, 2015

Conversation

non
Copy link
Contributor

@non non commented Nov 3, 2015

These laws are taken from this paper:
http://arxiv.org/pdf/0710.1163v3.pdf

Thanks to @jedws and @tpolecat for bringing this up.

We may also want to remove one of our existing
laws (F.pure(F.extract(fa)) <-> fa), but for now
I have left it alone.

This fixes #595

@non
Add two new laws for Bimonad.
56b9548 
These laws are taken from this paper:
http://arxiv.org/pdf/0710.1163v3.pdf

Thanks to @jedws and @tpolecat for bringing this up.

We may also want to remove one of our existing
laws (F.pure(F.extract(fa)) <-> fa), but for now
I have left it alone.
@non non added the in progress label Nov 3, 2015
@adelbertc
Copy link
Contributor

👍

@codecov-io
Copy link

Current coverage is 76.32%

Merging #596 into master will increase coverage by +0.11% as of 31ced18

@@            master    #596   diff @@
======================================
  Files          160     160       
  Stmts         2190    2196     +6
  Branches        68      68       
  Methods          0       0       
======================================
+ Hit           1669    1676     +7
  Partial          0       0       
+ Missed         521     520     -1

Review entire Coverage Diff as of 31ced18

Powered by Codecov. Updated on successful CI builds.

@fthomas
Copy link
Member

fthomas commented Nov 3, 2015

👍

ceedubs added a commit that referenced this pull request Nov 3, 2015
@ceedubs
Merge pull request #596 from non/topic/more-bimonad-laws
0bd5e0b 
Add two new laws for Bimonad.
@ceedubs ceedubs merged commit 0bd5e0b into master Nov 3, 2015
@fthomas fthomas mentioned this pull request Nov 3, 2015
Closed
@non non mentioned this pull request Nov 4, 2015
Merged
@non non deleted the topic/more-bimonad-laws branch April 28, 2016 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

review bimonad laws
5 participants
@non @adelbertc @codecov-io @fthomas @ceedubs