Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: repeat evaluation with Streaming.memoize #662

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: repeat evaluation with Streaming.memoize #662

wants to merge 1 commit into from

Commits on Nov 16, 2015

  1. Failing test: repeat evaluation with Streaming.memoize 

    This is a potential bug report and is not meant to be merged in its
current form.

This test fails. It attempts to check that if a `Streaming` instance is
created via `.memoize`, then its elements won't be evaluated multiple
times (such as when `.toList` is called).

One could argue that this is a bogus test case, since side effects
should be tracked in a type other than `Unit`. However, I believe that
this means that we might be evaluating arguments overly-eagerly, which
is a problem in itself.

I made a naive attempt at fixing this by making `Streaming.map` a little
lazier in the `Cons` case, but that didn't seem to do the trick.

@non do you have any thoughts?
    @ceedubs
    ceedubs committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    378d52c View commit details
    Browse the repository at this point in the history