Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with Streaming#thunk. #683

Merged
merged 3 commits into from
Nov 20, 2015
Merged

Fix bug with Streaming#thunk. #683

merged 3 commits into from
Nov 20, 2015

Commits on Nov 19, 2015

  1. Fix bug with Streaming#thunk. 

    The .thunk method is not supposed to memoize the results,
allowing the caller to provide an impure function which
returns different values on different calls.

However, .thunk's definition used .knot with memoization,
which completely defeated the point. This commit removes
the memoization allowing this method to function correctly.

Fixes #677.
    @non
    non committed Nov 19, 2015
    Configuration menu
    Copy the full SHA
    0278d90 View commit details
    Browse the repository at this point in the history

  2. Add test case to prove this is fixed.

    @non
    non committed Nov 19, 2015
    Configuration menu
    Copy the full SHA
    60f0686 View commit details
    Browse the repository at this point in the history

  3. Fix documentation for .thunk.

    @non
    non committed Nov 19, 2015
    Configuration menu
    Copy the full SHA
    e22c15d View commit details
    Browse the repository at this point in the history