Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert regression in Free.foldMap #713

Merged
merged 3 commits into from
Dec 7, 2015
Merged

Revert regression in Free.foldMap #713

merged 3 commits into from
Dec 7, 2015

Commits on Dec 4, 2015

  1. Include Gosub in Free Arbitrary instance 

    Before we were never hitting the Gosub case. This reveals a bug that is
causing the "mapSuspension id" test to fail.
    @ceedubs
    ceedubs committed Dec 4, 2015
    Configuration menu
    Copy the full SHA
    de40f83 View commit details
    Browse the repository at this point in the history

  2. Revert Free.foldMap regression 

    This reverts most of the changes from typelevel#702, because it appears to have
caused a regression in the case of Gosub. This commit fixes the
"mapSuspension id" unit test and the issue reported in typelevel#712.

The stack safety test is now failing. I've commented it out for now,
because an incorrectness bug seems to be worse than a stack safety
issue.
    @ceedubs
    ceedubs committed Dec 4, 2015
    Configuration menu
    Copy the full SHA
    c587300 View commit details
    Browse the repository at this point in the history

  3. Reduce depth of arbitrary Free instances

    @ceedubs
    ceedubs committed Dec 4, 2015
    Configuration menu
    Copy the full SHA
    6feb7d0 View commit details
    Browse the repository at this point in the history