Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup to Coproduct #756

Merged
merged 1 commit into from
Dec 16, 2015
Merged

Minor cleanup to Coproduct #756

merged 1 commit into from
Dec 16, 2015

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Dec 16, 2015

Use coflatMap instead of duplicate to be consistent with CoflatMap
and make CoproductComonad extend CoproductCoflatMap to reduce a couple
duplicated methods.

@raulraja would you want to take a look at this one?

@ceedubs
Minor cleanup to Coproduct
34f3817 
Use `coflatMap` instead of `duplicate` to be consistent with `CoflatMap`
and make CoproductComonad extends CoproductCoflatMap to reduce a couple
duplicated methods.
@adelbertc
Copy link
Contributor

👍 once Travis is green

@codecov-io
Copy link

Current coverage is 87.43%

Merging #756 into master will increase coverage by +0.21% as of 2363d73

@@            master    #756   diff @@
======================================
  Files          166     166       
  Stmts         2293    2292     -1
  Branches        74      74       
  Methods          0       0       
======================================
+ Hit           2000    2004     +4
  Partial          0       0       
+ Missed         293     288     -5

Review entire Coverage Diff as of 2363d73

Powered by Codecov. Updated on successful CI builds.

@raulraja
Copy link
Contributor

LGTM 👍

@milessabin
Copy link
Member

👍

milessabin added a commit that referenced this pull request Dec 16, 2015
@milessabin
Merge pull request #756 from ceedubs/coproduct-cleanup
258b289 
Minor cleanup to Coproduct
@milessabin milessabin merged commit 258b289 into typelevel:master Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ceedubs @adelbertc @codecov-io @raulraja @milessabin