Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contravariant documentation page #859

Merged
merged 3 commits into from
Feb 3, 2016

Conversation

vpavkin
Copy link
Contributor

@vpavkin vpavkin commented Feb 3, 2016

@vpavkin
Copy link
Contributor Author

vpavkin commented Feb 3, 2016

Appreciate any input/corrections :)

layout: default
title: "Contravariant"
section: "typeclasses"
source: "https://github.com/non/cats/blob/master/core/src/main/scala/cats/functor/Contravariant.scala"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should switch from non to typelevel. We probably have the same mistake in lots of docs. We could probably just give relative paths here and use site-wide config for the base source URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, but currently useful links section, with those source links is hidden...
I think this issue and all links should be fixed in another pr. I'll take care of that.

@ceedubs
Copy link
Contributor

ceedubs commented Feb 3, 2016

I made a few minor comments, but this is great. Thanks, @vpavkin!

@codecov-io
Copy link

Current coverage is 89.27%

Merging #859 into master will not affect coverage as of 92ab1fe

@@            master    #859   diff @@
======================================
  Files          168     168       
  Stmts         2322    2322       
  Branches        75      75       
  Methods          0       0       
======================================
  Hit           2073    2073       
  Partial          0       0       
  Missed         249     249       

Review entire Coverage Diff as of 92ab1fe

Powered by Codecov. Updated on successful CI builds.

@vpavkin
Copy link
Contributor Author

vpavkin commented Feb 3, 2016

@ceedubs I'm not a native speaker, thank you for covering my back here! :)
Fixed the minors, will open a separate pr with sources links fixed

@ceedubs
Copy link
Contributor

ceedubs commented Feb 3, 2016

👍

@non
Copy link
Contributor

non commented Feb 3, 2016

Thanks so much! 👍

non added a commit that referenced this pull request Feb 3, 2016
Add Contravariant documentation page
@non non merged commit cbe3597 into typelevel:master Feb 3, 2016
@vpavkin vpavkin deleted the contravariant-docs branch February 3, 2016 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants