Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .tell and .writer syntax for creating Writers. Fixes #920. #922

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Add .tell and .writer syntax for creating Writers. Fixes #920. #922

merged 1 commit into from
Mar 9, 2016

Conversation

davegurnell
Copy link

This adds the following syntax for the Writer monad, as outlined in #920:

log.tell

result.writer(log)

This is my first PR to Cats so there's probably stuff that's wrong in here. I'm happy to fix stuff if required, or close the PR if people think it's not worthwhile. I figured it was easier to have a discussion over a concrete PR than an issue.

@codecov-io
Copy link

Current coverage is 88.94%

Merging #922 into master will increase coverage by +0.16% as of 32e2bff

@@            master    #922   diff @@
======================================
  Files          178     179     +1
  Stmts         2122    2125     +3
  Branches        42      42       
  Methods          0       0       
======================================
+ Hit           1884    1890     +6
  Partial          0       0       
+ Missed         238     235     -3

Review entire Coverage Diff as of 32e2bff

Powered by Codecov. Updated on successful CI builds.

@non
Copy link
Contributor

non commented Mar 9, 2016

The syntax seems reasonable to me, as do the names. 👍

@stew
Copy link
Contributor

stew commented Mar 9, 2016

👍 Thanks Dave!

stew added a commit that referenced this pull request Mar 9, 2016
Add .tell and .writer syntax for creating Writers. Fixes #920.
@stew stew merged commit 92a3c5c into typelevel:master Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants