Onward to scala 2.11.8.

[paulp]

Unused import detection has improved, leading to a number
of deletions.

[paulp]

Oops, I accidentally snuck a couple new plugins in as well. That's actually what got me started on the whole thing, but I completely forgot until I skimmed the diff.

[mpilquist]

👍

[paulp]

So, let me know and I can carve off one or both of them. Coursier should be a slam dunk, the other one is a little more obscure - I just ran across it and found it handy.

[paulp]

Great! In my initial push the build failed because op was not found. After restoring it, the build fails because op is unused. It is perhaps unused during normal compilation but used during documentation generation. I don't know how to deal with this.

[info] Compiling 119 Scala sources to /home/travis/build/typelevel/cats/core/.jvm/target/scala-2.11/classes...
[error] /home/travis/build/typelevel/cats/core/src/main/scala/cats/SemigroupK.scala:3: Unused import
[error] import simulacrum.{op, typeclass}
[error]                    ^
[error] one error found
[error] (coreJVM/compile:compileIncremental) Compilation failed

[edmundnoble]

op is a macro annotation. Perhaps it's being expanded and removed, which is causing it to appear unused. I suggest fully qualifying the use of op for now and removing the import, seeing as it's the only use of op in the cats codebase. It looks like it will validate with that change.

[paulp]

Hah, I can't believe I didn't think of doing that.

[adelbertc]

👍 on Travis green

[paulp]

It all seems fine, but the builds hang up:

No output has been received in the last 10 minutes, this potentially
indicates a stalled build or something wrong with the build itself.
The build has been terminated

On my last push I removed those two plugins in case one was causing this, but it has happened again since. Has this happened before? My first guess would be memory exhaustion though I don't know why this commit would cross any threshold.

[DavidGregory084]

@paulp this seems to happen fairly frequently at the minute, see #810 and associated issues

[fthomas]

I've restarted the build.

[adelbertc]

And restart again......

[codecov-io]

Current coverage is 88.93%

Merging #938 into master will not affect coverage as of 043d506

@@            master    #938   diff @@
======================================
  Files          179     179       
  Stmts         2132    2133     +1
  Branches        42      42       
  Methods          0       0       
======================================
+ Hit           1896    1897     +1
  Partial          0       0       
  Missed         236     236       

Review entire Coverage Diff as of 043d506

Powered by Codecov. Updated on successful CI builds.

[ceedubs]

Fantastic. Thanks @paulp!