Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get nested field for struct column #545

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

cchantep
Copy link
Collaborator

@cchantep cchantep commented Aug 7, 2021

No description provided.

@cchantep
Copy link
Collaborator Author

@imarios review welcome

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks like a pretty reasonable addition to me, nice!

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #545 (bcd6432) into master (45d7a60) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #545   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files          61       61           
  Lines        1050     1051    +1     
  Branches        7        5    -2     
=======================================
+ Hits         1011     1012    +1     
  Misses         39       39           
Flag Coverage Δ
2.12.14 96.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...taset/src/main/scala/frameless/RecordEncoder.scala 100.00% <ø> (ø)
dataset/src/main/scala/frameless/TypedColumn.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d7a60...bcd6432. Read the comment docs.

@cchantep cchantep merged commit 4fa07fd into typelevel:master Aug 25, 2021
@cchantep cchantep deleted the feature/col-field branch August 25, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants